Skip to content

feat: enable find in result pane #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scnwwu merged 1 commit into from
Nov 4, 2024
Merged

feat: enable find in result pane #714

scnwwu merged 1 commit into from
Nov 4, 2024

Conversation

@scnwwu
Copy link
Contributor

@scnwwu scnwwu commented Dec 19, 2023

Summary
Resolve #700

Testing

  1. Run code to get HTML result
  2. Focus in the Result pane
  3. Press the find shortcut (by default Ctrl+F on Windows)

@scnwwu scnwwu added this to the 1.7.0 milestone Dec 21, 2023
@Zhirong2022 Zhirong2022 added testing Test the pull requests and removed verification-needed labels Dec 21, 2023
@Zhirong2022
Copy link

Zhirong2022 commented Dec 25, 2023

VSC will quit in certain case

  1. Run some SAS code
  2. Ctrl+f to open Find control
  3. Type something in find input box and perform search, then keep Find control on the page
  4. Click other tab page
  5. Click result tab page, VSC will quit unexpectedly

@scnwwu
Copy link
Contributor Author

scnwwu commented Dec 25, 2023

VSC will quit in certain case

  1. Run some SAS code
  2. Ctrl+f to open Find control
  3. Type something in find input box and perform search, then keep Find control on the page
  4. Click other tab page
  5. Click result tab page, VSC will quit unexpectedly

Reported to microsoft/vscode#201478

@scnwwu scnwwu removed the testing Test the pull requests label Jan 17, 2024
@scnwwu
Copy link
Contributor Author

scnwwu commented Jan 17, 2024 •
edited
Loading

Blocked by the VS Code issue. Will revisit after the blocking issue resolved.

@scnwwu scnwwu removed this from the 1.7.0 milestone Feb 2, 2024
@scnwwu scnwwu force-pushed the p-findresult branch 2 times, most recently from 73b130f to 3d40b2d Compare October 31, 2024 05:22
@scnwwu scnwwu added the testing Test the pull requests label Oct 31, 2024
@scnwwu
Copy link
Contributor Author

scnwwu commented Oct 31, 2024

The bug of VS Code has been fixed. Please move on testing on latest VS Code (1.95). Thanks.

@Zhirong2022 Zhirong2022 removed the testing Test the pull requests label Nov 4, 2024
@Zhirong2022
Copy link

Zhirong2022 commented Nov 4, 2024

The feature works as expected. The user can open find dialog on result page and do some search.

@scnwwu scnwwu added this to the 1.12.0 milestone Nov 4, 2024
@scnwwu scnwwu merged commit a010b66 into sassoftware:main Nov 4, 2024
2 checks passed
@scnwwu scnwwu deleted the p-findresult branch November 4, 2024 07:49
@Zhirong2022 Zhirong2022 added the testing-complete Complete the pull requests testing label Nov 8, 2024
@Zhirong2022 Zhirong2022 added ready for release Code pushed, but not released in VS code marketplace yet and removed testing-complete Complete the pull requests testing labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottdover scottdover scottdover approved these changes

@Zhirong2022 Zhirong2022 Zhirong2022 approved these changes

@smorrisj smorrisj Awaiting requested review from smorrisj

Assignees

@Zhirong2022 Zhirong2022

Labels

ready for release Code pushed, but not released in VS code marketplace yet

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Search in Result pane

3 participants

@scnwwu @Zhirong2022 @scottdover