Open
Conversation
jcelerier
reviewed
Mar 19, 2026
CMakeLists.txt
Outdated
| if (LINUX) | ||
| # fetch libOrbbecSDK.dll when compiling under windows. | ||
| add_custom_command(TARGET ${LIBNAME} POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E copy "$<TARGET_FILE:OrbbecSDK>" "${GODOT_PROJECT_BINARY_DIR}/libOrbbecSDK.so.2.5.5" |
There was a problem hiding this comment.
I think this should try to look for the actual version number shipped by the orbbec SDK as it will break on every update otherwise
Member
Author
There was a problem hiding this comment.
Should be fixed.
|
will try asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linux
.sofiles created by the CI had hard paths to the build folder in theirrunpath. This PR bundles the variouslibOrbbecSDK.sofiles with the main.sofile and makes it so the main.sofile tries to find the orbbec sdk in various places that makes sense when running the extension either from the godot editor or an exported project.I have tested deleting every build artifact from my machine and replacing them by this and it now works both in exported versions and in the editor.