fix: Fallback Regex #200
Open
fix: Fallback Regex #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borketh
requested changes
Oct 26, 2025
Member
Borketh
left a comment
Borketh
left a comment
There was a problem hiding this comment.
Could these safe regex functions be put in a new file in the libraries directory? Crashes is already a massive file. This way we can also use them elsewhere if needed.
Please also run the black formatter.
Member
|
closes #193 |
Member
Member
|
@rhit-daughewd is currently investigating switching to use pyre2's fallback feature and if that works for our use case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.