fix: clear BackToTop float to prevent nav layout shift#623
Open
mathieumaf wants to merge 1 commit intosatnaing:mainfrom
Open
fix: clear BackToTop float to prevent nav layout shift#623mathieumaf wants to merge 1 commit intosatnaing:mainfrom
mathieumaf wants to merge 1 commit intosatnaing:mainfrom
Conversation
…v layout When SHARE_LINKS is empty, the BackToTopButton's md:float-end was not cleared before the prev/next navigation grid, pushing buttons out of alignment. Adding clear-end on the separating <hr> fixes this. Fixes satnaing#614 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SHARE_LINKS is empty, the BackToTopButton's md:float-end was not cleared before the prev/next navigation grid, pushing buttons out of alignment. Adding clear-end on the separating
<hr>fixes this.Fixes #614
Description
When
SHARE_LINKSis empty insrc/constants.ts, theShareLinkscomponent renders nothing. This means theBackToTopButton'smd:float-endis not cleared before the prev/next navigation grid, causing the "Next Post" / "Previous Post" buttons to shift left instead of staying properly aligned.The fix adds
clear-endon the<hr>that separates the share links section from the navigation, ensuring the float is always cleared regardless of whether share links are present.Types of changes
Checklist
Further comments
Single-line change in
src/layouts/PostDetails.astro(line 129):Tested both with empty and populated
SHARE_LINKS— no regression.Related Issue
Closes: #614