Adding duckdb exceptions and result fetch methods#1
Open
chrisBirmingham wants to merge 13 commits intosatur-io:mainfrom
Open
Adding duckdb exceptions and result fetch methods#1chrisBirmingham wants to merge 13 commits intosatur-io:mainfrom
chrisBirmingham wants to merge 13 commits intosatur-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
Thank you for all your work bringing duckdb to PHP.
This PR adds three new exceptions to the extension, DuckDBException, ConnectionException and QueryException, that are thrown when duckdb fails to connect or query the database. To facilitate this, I've moved the object creation code to the bottom of each function as I've found PHP will fatal if you create the class then throw an exception.
I've also removed the USED_RET code path as I've found that running the code
Would fatal as PHP returned true instead of the result object.
Edit:
I've also updated the PR to include two new fetch methods on the result class that allows pdo style fetching of rows along with adding a usage section to the readme