User callbacks for send failures#61
Merged
satyamjay-iitd merged 3 commits intomasterfrom Oct 21, 2025
Merged
Conversation
Owner
|
satyamjay-iitd
requested changes
Sep 27, 2025
Collaborator
Author
Cool this seems to work for local sender, but I'm confused for remote sender (FramedWrite). Apparently it depends on the encoder to make the msg recoverable? Is adding a trait impl for the encoder to recover msg the right direction? @satyamjay-iitd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes to resolve:
E::Error: Send + 'staticin multiple places inactor/src/send.rsto resolve the error of:Retry, msg gets cloned even for successful sends. Bad for efficiency.Retrycan be extended to also include timeout delayOther decisions:
Retry5 times with 100 ms delay.Closes #56