fix: merge proxy into project-level contextOptions#315
Merged
mayank-at-sauce merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
konraddysput
approved these changes
Feb 18, 2026
Playwright resolves project config by replacing root-level `use` properties with project-level ones. When a project defines its own `use.contextOptions` (e.g. reducedMotion), it completely overrides the root-level contextOptions — losing the SC tunnel proxy settings and causing scripted requests to fail with ENOTFOUND. This iterates over user-defined projects and merges proxy settings into each project's contextOptions so both coexist. Fixes INT-11 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
77f6bbf to
a2acba2
Compare
mayank-at-sauce
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use.contextOptions(e.g.{ reducedMotion: 'reduce' }), Playwright replaces the root-levelcontextOptionsentirely instead of deep-merging themgetaddrinfo ENOTFOUNDerrors for scripted requestscontextOptions, so both the user's settings and the proxy coexistFixes INT-11
Test plan
npm test)contextOptionsat the project level (e.g.reducedMotion: 'reduce') and confirm the SC tunnel proxy is preservedcontextOptionsonly at the root level (existing behavior, should be unchanged)contextOptionsat all (existing behavior, should be unchanged)