Merged
Conversation
Playwright resolves project config by replacing root-level `use` properties with project-level ones. When a project defines its own `use.contextOptions` (e.g. reducedMotion), it completely overrides the root-level contextOptions — losing the SC tunnel proxy settings and causing scripted requests to fail with ENOTFOUND. This iterates over user-defined projects and merges proxy settings into each project's contextOptions so both coexist. Fixes INT-11 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nitinkumar-saucelabs
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/bundle.macos.shto use directory isolation for multi-arch browser bundling instead of the previous backup/restore +INSTALLATION_COMPLETEmarker manipulation approach.Problem
The previous bundling strategy installed ARM64 and x64 browsers into a single shared cache directory, requiring:
INSTALLATION_COMPLETEmarkers to force Playwright to re-download x64 variantsThis broke on Playwright 1.58.1, which dropped webkit support for
mac13. The blanket marker deletion caused Playwright to attempt reinstalling webkit formac13, resulting in:ERROR: Playwright does not support webkit on mac13.Solution
ARM64 and x64 browsers are now installed into separate isolated directories (
Cache-arm64/,Cache-intel/), then merged into the finalCache/usingrsync --ignore-existing:Cache-arm64/Cache-intel/rsync -a --ignore-existing, clean up temp dirsThis eliminates all
INSTALLATION_COMPLETEmarker manipulation and the backup/restore dance entirely. Each install is fully isolated — no risk of one corrupting the other.Browser architecture mapping (unchanged from #313)
Test plan
build-macos-bundleCI job passes (no webkit mac13 error)bundle-testandbundle-test-with-sauce-connectjobs pass downstreamchrome-mac-arm64/andchrome-mac-x64/in final cache