Skip to content

Java visual update to remove VisualResults #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nadvolod wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Java visual update to remove VisualResults #290

nadvolod wants to merge 28 commits into from

Conversation

@nadvolod
Copy link
Contributor

@nadvolod nadvolod commented Apr 1, 2022 •
edited
Loading

Removing VisualResults from Java.
Updated the API to make projectName and testName mandatory in all of the appropriate constructors.
Add advanced data driven visual example.

@nadvolod nadvolod added the java Java Bindings label Apr 1, 2022
nadvolod and others added 17 commits April 1, 2022 14:28
@nadvolod
fix test values
f375abc
@nadvolod
adding java version to test name
53d8d63
@nadvolod
remove main + junit4 from jdk9.yml
9637575
@nadvolod
remove dynamic java stuff
e724f56
@nadvolod
fix build name and number
2edd38e
@titusfortner @nadvolod
[java] checkstyle settings for codacy based on github and updates fro…
3286a7b 
…m saucelabs-training/demo-java repo
@titusfortner @nadvolod
[java] fix checkstyle error
c8c7352
@titusfortner @nadvolod
[java] remove static imports from tests
a6a9270
@titusfortner @nadvolod
[ruby] update changelog and bump version to 1.3.0
568518b
@titusfortner @nadvolod
[python] update changelog and bump version to 1.3.0
a17ab9a
@titusfortner @nadvolod
[maven-release-plugin] prepare release java-1.3.0
967983b
@titusfortner @nadvolod
[maven-release-plugin] prepare for next development iteration
b78bb6e
@nadvolod
fix broken data center tests
8a3fbb2
@nadvolod
deprectated stop method in VisualSession.java
cbfe26a
@nadvolod
remove unecessary stop()
a195717
@nadvolod
Update visualOptions to have a 2 parameter constructor
379fc25
@nadvolod
Start of a data driven test
425b01c
@nadvolod
Copy link
Contributor Author

nadvolod commented Jul 15, 2022

Need to add examples like here https://github.com/saucelabs-training/demo-java/blob/main/selenium-junit4-examples/src/test/java/com/saucedemo/selenium/junit4/SimpleVisualE2ETest.java#L115-L158
Also, should create some docs on how to make the transition from old way to new way

@nadvolod nadvolod mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titusfortner titusfortner Awaiting requested review from titusfortner

@c3ccl3ston c3ccl3ston Awaiting requested review from c3ccl3ston

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

java Java Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nadvolod @titusfortner