Skip to content

Bug Fix: rtrim was erroneously removing s in Models#148

Merged
coolsam726 merged 1 commit intomainfrom
features
Sep 3, 2025
Merged

Bug Fix: rtrim was erroneously removing s in Models#148
coolsam726 merged 1 commit intomainfrom
features

Conversation

@coolsam726
Copy link
Contributor

- Use beforeLast instead of rtrim when generating resources
@what-the-diff
Copy link

what-the-diff bot commented Sep 3, 2025

🎉 PR Summary 🚀

  • Refreshing Model Namespace Extraction Method 😊
    We've updated our way of getting the $modelNamespace (a kind of "address" for certain parts of our code). Instead of using rtrim(), we now use beforeLast(). This change helps us ensure that we're correctly extracting the namespace, making the code much more reliable. Your confidence in our system is important to us! 👍

@coolsam726 coolsam726 merged commit e831c36 into main Sep 3, 2025
2 of 27 checks passed
@coolsam726 coolsam726 deleted the features branch September 3, 2025 18:34
@coolsam726 coolsam726 restored the features branch September 8, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Generated file does not respect configured path from nWidart package

1 participant

Comments