Remove notify watch, use local socket IPC for changes feed #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would have been nice to use a compile time check such as vec1::Vec1 but that over-complicates the API and adds more dependencies so we just bail early and return a default CommitSpan when the event records are empty.
As there can be multiple browsers (and browser extensions) running and hence multiple consumers.
Yet another Windows quirk.
In the database upgrade logic.
So that we remove the file system watching logic and receive events from the changes consumer instead.
Prevents the gui code from triggering a compiler error due to the files feature being enabled elsewhere.
No longer assumes a file system backend but expects a BackendTarget to be passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #681 and closes #736.