-
Notifications
You must be signed in to change notification settings - Fork 3
Convert Human Era to toggle with implicit API-level date filtering #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a2bf13
Initial plan
Copilot e57c2e3
Convert Human Era from button to toggle switch with implicit API filt…
Copilot 2ca3691
Refactor: Extract date filter logic to utility function and add tests
Copilot b38682d
Address code review: Remove unused import and improve filter detection
Copilot ccddfeb
Security fix: Properly escape all regex special characters including …
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { addDateFilterToQuery } from './queryFilter'; | ||
|
|
||
| describe('addDateFilterToQuery', () => { | ||
| const dateFilter = 'date < sec(2023-01-01)'; | ||
|
|
||
| it('should add filter to simple query', () => { | ||
| const result = addDateFilterToQuery('技术', dateFilter); | ||
| expect(result).toBe('技术 (date < sec(2023-01-01))'); | ||
| }); | ||
|
|
||
| it('should add filter to empty query', () => { | ||
| const result = addDateFilterToQuery('', dateFilter); | ||
| expect(result).toBe('(date < sec(2023-01-01))'); | ||
| }); | ||
|
|
||
| it('should not duplicate filter if already present', () => { | ||
| const query = '技术 (date < sec(2023-01-01))'; | ||
| const result = addDateFilterToQuery(query, dateFilter); | ||
| expect(result).toBe(query); | ||
| }); | ||
|
|
||
| it('should combine with existing filter using AND', () => { | ||
| const query = '技术 (author=test)'; | ||
| const result = addDateFilterToQuery(query, dateFilter); | ||
| expect(result).toBe('技术 (author=test AND date < sec(2023-01-01))'); | ||
| }); | ||
|
|
||
| it('should handle query with whitespace', () => { | ||
| const result = addDateFilterToQuery(' 技术 ', dateFilter); | ||
| expect(result).toBe('技术 (date < sec(2023-01-01))'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /** | ||
| * Utility functions for combining search queries with filters | ||
| */ | ||
|
|
||
| /** | ||
| * Checks if a query already contains a specific date filter | ||
| * Uses more specific matching to avoid false positives | ||
| */ | ||
| function hasDateFilter(query: string, dateFilter: string): boolean { | ||
| // Match the filter when it's wrapped in parentheses or at the end | ||
| const filterPattern = new RegExp(`\\(${dateFilter.replace(/[()]/g, '\\$&')}\\)`, 'i'); | ||
| return filterPattern.test(query); | ||
| } | ||
|
|
||
| /** | ||
| * Combines a search query with a date filter | ||
| * @param query - The original search query | ||
| * @param dateFilter - The date filter expression to add | ||
| * @returns The combined query with the date filter applied | ||
| */ | ||
| export function addDateFilterToQuery(query: string, dateFilter: string): string { | ||
| const trimmedQuery = query.trim(); | ||
| const filterExpression = `(${dateFilter})`; | ||
|
|
||
| // Check if the query already contains the date filter | ||
| if (hasDateFilter(trimmedQuery, dateFilter)) { | ||
| return trimmedQuery; | ||
| } | ||
|
|
||
| // Check if current query already has a filter (ends with parenthesis) | ||
| if (trimmedQuery.endsWith(")")) { | ||
| // Extract simple query and existing filter | ||
| const firstParen = trimmedQuery.indexOf("("); | ||
| if (firstParen !== -1) { | ||
| const simpleQuery = trimmedQuery.substring(0, firstParen).trim(); | ||
| const existingFilter = trimmedQuery.substring(firstParen); | ||
| // Combine filters with AND | ||
| const combinedFilter = `(${existingFilter.slice(1, -1)} AND ${dateFilter})`; | ||
| return simpleQuery ? `${simpleQuery} ${combinedFilter}` : combinedFilter; | ||
| } | ||
| // Should not happen, but fallback | ||
| return `${trimmedQuery} ${filterExpression}`; | ||
| } | ||
|
|
||
| // Simple query or empty, append filter | ||
| return trimmedQuery ? `${trimmedQuery} ${filterExpression}` : filterExpression; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.