Skip to content

mainfile #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

mainfile #10

merged 1 commit into from
Oct 30, 2024

Conversation

sayedpfe
Copy link
Owner

This pull request includes significant updates to the src/InfrastructureAsCode/main.bicep file, primarily focusing on the configuration and deployment of various Azure resources. The changes include updating the SKU for the app service plan, adding resources for log analytics, application insights, container registry, and app service plan, and configuring the app service application.

Key changes include:

Resource Configuration Updates:

  • Changed the SKU for the app service plan from 'S1' to 'P0V3'.

New Resource Additions:

  • Added a logAnalyticsWorkspace resource with specific properties including SKU, retention policy, and workspace capping.
  • Added an appInsights resource linked to the logAnalyticsWorkspace.
  • Added a containerRegistry resource with admin user enabled.
  • Added an appServicePlan resource configured for Linux with the updated SKU.
  • Added an appServiceApp resource with detailed site configuration, including Docker settings and application insights instrumentation key.

Output Additions:

  • Added outputs for application_name, application_url, and container_registry_name.

@sayedpfe sayedpfe merged commit ef482ac into main Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants