Adding extra config to allow any configuration to be added#182
Adding extra config to allow any configuration to be added#182MontyBeda wants to merge 2 commits intosaz:masterfrom
Conversation
|
Thank you for the PR. I'm not really sure, if I like it or not. On the one hand, it will make this module way more flexible, on the other hand, it raises the question "when will a new parameter be added?". Besides that, the REFERENCE.md file is outdated, please run Currently, this PR is only changing |
|
It is your module so I let it for your decision. I need it for the data permanence upon server restart only at the moment. But there are few more parameters that cannot be set in the module at the moment and this would just easily enable setting them all up. If you have the time to add all the parameters then great but this should provide a lot of flexibility to users of the module. |
|
@MontyBeda Do you have a list of parameters, which you're currently missing? |
|
I miss only -e for setting ramdisk for cachdisk for Warm reboot. As per https://docs.memcached.org/features/restart/ |
Adding param extra_config that will allow any extra configuration to be added to Memcached configuration file. Useful for example to add persistent data when restarting Memcached service but can be used for anything added in the future as well.