Feat/progressive blur #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitions - Implement VariableBlurView using private CA filters for smooth gradient blur - Add ProgressiveBlurView React Native component (iOS only) - Support bidirectional blur (top-to-bottom, bottom-to-top) - Add startOffset control for gradient positioning - Use smoothLinearGradient for improved transition quality - Create example screen with locked content use case - Add Fabric codegen support and TypeScript definitions
- Add ReactNativeProgressiveBlurView extending QmBlurView's ProgressiveBlurView - Map blur amounts (0-100) to Android blur radius (0-25) for consistency - Update docs to reflect Android support for ProgressiveBlurView - Remove iOS-only platform checks from component and example screen
…radient approach - implementation using BlurView and linear gradient mask - Add support for directional gradients and startOffset for improved flexibility - Simplify reflection-based hacks and improve reliability of blur effect rendering
Contributor
Reviewer's GuideThis PR introduces a brand-new ProgressiveBlurView component built with native Android and iOS modules for gradient blur effects, refactors the existing BlurView’s type handling, updates package exports, and refreshes documentation and example app to cover the new API. ER diagram for new ProgressiveBlurViewProps and related typeserDiagram
ProgressiveBlurViewProps {
blurType string
blurAmount number
direction string
startOffset number
reducedTransparencyFallbackColor string
style ViewStyle
children ReactNode
}
ProgressiveBlurViewProps ||--o| ProgressiveBlurDirection : uses
ProgressiveBlurViewProps ||--o| BlurType : uses
Class diagram for new ProgressiveBlurView and related typesclassDiagram
class ProgressiveBlurView {
+blurType: BlurType
+blurAmount: number
+direction: ProgressiveBlurDirection
+startOffset: number
+reducedTransparencyFallbackColor: string
+style: ViewStyle
+children: ReactNode
+updateBlur()
}
class VariableBlurView {
+maxBlurRadius: CGFloat
+direction: VariableBlurDirection
+startOffset: CGFloat
+updateBlur()
}
class ReactNativeProgressiveBlurViewNativeComponent {
+blurAmount: number
+blurType: BlurType
+direction: ProgressiveBlurDirection
+startOffset: number
+reducedTransparencyFallbackColor: string
}
ProgressiveBlurView --> ReactNativeProgressiveBlurViewNativeComponent
ProgressiveBlurView --> VariableBlurView
VariableBlurView <|-- ProgressiveBlurView
Class diagram for updated BlurType enum (Android)classDiagram
class BlurType {
+XLIGHT
+LIGHT
+DARK
+EXTRA_DARK
+REGULAR
+PROMINENT
+SYSTEM_ULTRA_THIN_MATERIAL
+SYSTEM_ULTRA_THIN_MATERIAL_LIGHT
+SYSTEM_ULTRA_THIN_MATERIAL_DARK
+SYSTEM_THIN_MATERIAL
+SYSTEM_THIN_MATERIAL_LIGHT
+SYSTEM_THIN_MATERIAL_DARK
+SYSTEM_MATERIAL
+SYSTEM_MATERIAL_LIGHT
+SYSTEM_MATERIAL_DARK
+SYSTEM_THICK_MATERIAL
+SYSTEM_THICK_MATERIAL_LIGHT
+SYSTEM_THICK_MATERIAL_DARK
+SYSTEM_CHROME_MATERIAL
+SYSTEM_CHROME_MATERIAL_LIGHT
+SYSTEM_CHROME_MATERIAL_DARK
+fromString(type: String): BlurType
+overlayColor: Int
}
Class diagram for new ReactNativeProgressiveBlurView (Android)classDiagram
class ReactNativeProgressiveBlurView {
-blurView: BlurView
-gradientPaint: Paint
-currentBlurRadius: Float
-currentOverlayColor: Int
-currentDirection: String
-currentStartOffset: Float
-hasExplicitBackground: Boolean
+setBlurAmount(amount: Float)
+setDirection(direction: String)
+setStartOffset(offset: Float)
+setBlurType(type: String)
+setReducedTransparencyFallbackColor(color: String?)
+cleanup()
}
ReactNativeProgressiveBlurView --> BlurView
Class diagram for new ProgressiveBlurView (iOS)classDiagram
class ProgressiveBlurView {
-variableBlurView: VariableBlurView
+blurAmount: Double
+direction: String
+startOffset: Double
+blurTypeString: String
+reducedTransparencyFallbackColor: UIColor
+updateBlur()
}
ProgressiveBlurView --> VariableBlurView
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Owner
Author
|
@DanielAraldi it is ready finally :D |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The Android mapBlurAmountToRadius helper uses MAX_BLUR_RADIUS in the denominator (clampedAmount / MAX_BLUR_RADIUS * MAX_BLUR_RADIUS) which effectively returns the input; you probably intended to normalize against MAX_BLUR_AMOUNT (0–100) and then scale to MAX_BLUR_RADIUS (0–25).
- This PR is very large and mixes README/docs changes, Android/iOS native code, and example app updates—consider splitting it into smaller, focused PRs (e.g. docs vs. Android vs. iOS vs. examples) to make review and testing more manageable.
- Using raw strings for blurType and direction increases the chance of typos—consider surfacing these as typed enums or union types on the JS side to improve discoverability and safety.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Android mapBlurAmountToRadius helper uses MAX_BLUR_RADIUS in the denominator (clampedAmount / MAX_BLUR_RADIUS * MAX_BLUR_RADIUS) which effectively returns the input; you probably intended to normalize against MAX_BLUR_AMOUNT (0–100) and then scale to MAX_BLUR_RADIUS (0–25).
- This PR is very large and mixes README/docs changes, Android/iOS native code, and example app updates—consider splitting it into smaller, focused PRs (e.g. docs vs. Android vs. iOS vs. examples) to make review and testing more manageable.
- Using raw strings for blurType and direction increases the chance of typos—consider surfacing these as typed enums or union types on the JS side to improve discoverability and safety.
## Individual Comments
### Comment 1
<location> `ios/Views/VariableBlurView.swift:81` </location>
<code_context>
+ return
+ }
+
+ let gradientImage = makeGradientImage(
+ startOffset: startOffset,
+ direction: direction
</code_context>
<issue_to_address>
**suggestion:** Gradient image generation uses fixed dimensions; consider adapting to view size for best results.
Currently, the gradient image uses a hardcoded 100x100 size. Generating it based on the view's actual dimensions will improve appearance, particularly for larger or differently shaped views.
Suggested implementation:
```
let gradientImage = makeGradientImage(
startOffset: startOffset,
direction: direction,
size: bounds.size
)
```
You will also need to update the `makeGradientImage` function definition to accept a `size: CGSize` parameter and use it to set the image dimensions, replacing any hardcoded values (such as 100x100).
</issue_to_address>
### Comment 2
<location> `README.md:136` </location>
<code_context>
## Features
-- � **Two Specialized Components**:
+- � **Three Specialized Components**:
- `BlurView` - Dedicated blur effects component with multiple blur types
+ - `ProgressiveBlurView` - Variable/gradient blur transitions (iOS & Android)
</code_context>
<issue_to_address>
**issue (typo):** The '�' character appears to be a corrupted emoji or symbol.
Replace or remove the '�' character to improve clarity.
Suggested implementation:
```
- 🧩 **Three Specialized Components**:
```
```
- 🌊 **Liquid Glass Effects**: Revolutionary glass effects using iOS 26+ UIGlassEffect API
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| return | ||
| } | ||
|
|
||
| let gradientImage = makeGradientImage( |
Contributor
There was a problem hiding this comment.
suggestion: Gradient image generation uses fixed dimensions; consider adapting to view size for best results.
Currently, the gradient image uses a hardcoded 100x100 size. Generating it based on the view's actual dimensions will improve appearance, particularly for larger or differently shaped views.
Suggested implementation:
let gradientImage = makeGradientImage(
startOffset: startOffset,
direction: direction,
size: bounds.size
)
You will also need to update the makeGradientImage function definition to accept a size: CGSize parameter and use it to set the image dimensions, replacing any hardcoded values (such as 100x100).
DanielAraldi
added
documentation
Collaborator
|
Very nice!! I’ll go to testing this feature tomorrow, ok? |
Owner
Author
|
@DanielAraldi take your timer brother |
DanielAraldi
approved these changes
Nov 15, 2025
Collaborator
DanielAraldi
left a comment
DanielAraldi
left a comment
There was a problem hiding this comment.
That’s works perfectly for me!! ProgressiveBlur implementation is amazing advance!
Collaborator
|
@sbaiahmed1 can merge it 🎉🎉 |
Owner
Author
Glad you liked it and it worked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #10
Summary by Sourcery
Add a new ProgressiveBlurView component with native Android and iOS implementations for smooth gradient blur effects, update the README and example app to demonstrate its usage, and refine Android blur type handling.
New Features:
Enhancements:
Documentation:
Chores: