Skip to content

Fix NullPointerException in AbstractTreeNode used by ASTNode clone #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dyrpsf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NullPointerException in AbstractTreeNode used by ASTNode clone #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/org/sbml/jsbml/AbstractTreeNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,10 @@ public AbstractTreeNode(TreeNode node) {
AbstractTreeNode anode = (AbstractTreeNode) node;
// Do not clone listeners!
// this.listOfListeners.addAll(anode.listOfListeners);
if (anode.isSetUserObjects()) {
userObjects = new HashMap<Object, Object>();
userObjects.putAll(anode.userObjects);
// Copy userObjects if present. We must not rely on isSetUserObjects(),
// because subclasses may override it with different semantics.
if (anode.userObjects != null && !anode.userObjects.isEmpty()) {
userObjects = new HashMap<Object, Object>(anode.userObjects);
}

// TODO - add this for all objects when we start using the checkAttribute method for other classes than Compartment.
Expand Down