Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the clang-format-check workflow with a more comprehensive cpp-linter workflow. The new workflow uses cpp-linter-action which can perform both formatting checks (using clang-format) and static analysis (using clang-tidy), though the latter is currently disabled.
Changes:
- Adds a new cpp-linter workflow that checks C/C++/Objective-C files on push and pull requests to main branch
- Removes the previous clang-format-check workflow
- Expands file coverage from just
Sources/CSFBAudioEngineto all C/C++ files in the repository
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/cpp-linter.yml | New workflow using cpp-linter-action v2 to perform formatting checks with thread comments on PRs, replacing the previous clang-format workflow |
| .github/workflows/clang-format-check.yml | Removed the previous clang-format workflow that used jidicula/clang-format-action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| style: 'file' | ||
| tidy-checks: '-*' |
There was a problem hiding this comment.
Setting tidy-checks: '-*' disables all clang-tidy checks. This significantly reduces the value of the linter since it will only perform clang-format style checks but no static analysis. Consider enabling at least some basic checks or removing this parameter to use the default checks, especially since the previous workflow only performed format checking. If the intention is to only check formatting for now, this is acceptable but should be documented or reconsidered for future improvements.
| tidy-checks: '-*' |
Added permissions for pull requests and enabled format review.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated cpp-linter workflow to target specific paths in the Sources/CSFBAudioEngine directory.
No description provided.