Skip to content

Short circuit processing graph logging if disabled#876

Merged
sbooth merged 1 commit intomainfrom
log
Feb 16, 2026
Merged

Short circuit processing graph logging if disabled#876
sbooth merged 1 commit intomainfrom
log

Conversation

@sbooth
Copy link
Owner

@sbooth sbooth commented Feb 16, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 16, 2026 17:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes debug logging for AudioPlayer by avoiding construction of the processing-graph description string when the target os_log type is disabled.

Changes:

  • Added an early-return guard using os_log_type_enabled(log, type) in AudioPlayer::logProcessingGraphDescription.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbooth sbooth merged commit 610306c into main Feb 16, 2026
8 checks passed
@sbooth sbooth deleted the log branch February 16, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant