Open
Conversation
Contributor
Author
|
I guess don't exactly know how the testing part works, can somebody help on this part? |
Member
|
Could you run |
Contributor
Author
|
Of course, done |
eed3si9n
reviewed
Sep 2, 2025
build.sbt
Outdated
|
|
||
| ThisBuild / (pluginCrossBuild / sbtVersion) := { | ||
| scalaBinaryVersion.value match { | ||
| case "2.12" => "1.5.8" |
Member
There was a problem hiding this comment.
Suggested change
| case "2.12" => "1.5.8" | |
| case "2.12" => "1.9.9" |
If this plugin wants to run tests on JDK 21, then the minimum version should be 1.9.9.
Member
|
https://github.com/sbt/sbt-osgi/blob/main/.scalafmt.conf probably needs to be updated to runner.dialect = Scala212Source3 |
Contributor
Author
|
Thanks, that's a lot better. Some test are not passing yet. For what I understand it seems to be caused by some sbt 2 instabilities. Is that what you get from the error as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first version of sbt-osgi cross compling to sbt 2.0.
I did the strict minimum to make the plugin and the test compile and run, so it is mergeable.
There is more to do especially on the caching side. I'll work on it when I'll have some time.