ReleasePlugin should be disabled when JvmPlugin is disabled#159
ReleasePlugin should be disabled when JvmPlugin is disabled#159Atry wants to merge 1 commit intosbt:masterfrom
Conversation
Because ReleasePlugin requires settings like managedClasspath defined in JvmPlugin
|
Ping @jroper |
|
I think it would be better to make those dependencies optional, ie depend on managedClasspath only if it's set. I don't think release plugin should depend on JvmPlugin, it's conceivable that you may release an sbt project that doesn't use the JVM. |
|
In order to make these dependencies optional and still keep the same behavior of the current sbt-release, we need the following steps:
|
|
Hi, @jroper , Since this PR is a bug fix, could you merge this PR for now? Without this PR, if some one added sbt-release dependency in |
|
I'll merge if you update it to make the dependency on val maybeClasspath: Option[Classpath] = managedClasspath.?.valueRequiring the Also, I'd like to see a scripted test added to ensure that the bug is fixed and doesn't regress in future. |
Because ReleasePlugin requires settings like managedClasspath defined in JvmPlugin