No /trunk, /branches or /tags part found in svn (issues 155)#161
Open
neoramon wants to merge 2 commits intosbt:masterfrom
Open
No /trunk, /branches or /tags part found in svn (issues 155)#161neoramon wants to merge 2 commits intosbt:masterfrom
neoramon wants to merge 2 commits intosbt:masterfrom
Conversation
java.lang.IllegalArgumentException: requirement failed: No /trunk, /branches or /tags part found in svn url sbt#155
|
Any plans to merge this PR? I'm using SVN and this would be useful in my project |
Member
|
could you write some tests? |
kotya
approved these changes
May 28, 2018
kotya
left a comment
kotya
left a comment
There was a problem hiding this comment.
I validated this change locally. Works well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.lang.IllegalArgumentException: requirement failed: No /trunk,
/branches or /tags part found in svn url
#155
The "val svnInfo = cmd("info").!!" get only first line, I changed to get all lines.
But anyway, I think useful allow to set the svn URL by property in build.sbt (like maven SCM), because with checkout of svn repository with several projects it is going to set baseDir root directory ex:
-- erp (root with .svn)
---- customer
------trunk
------branches
------tags
---- sales
------trunk
------branches
------tags
....
The baseDir will be erp without trunk, branches or tags.