Skip to content

Reviving NanocPlugin#212

Open
ASRagab wants to merge 3 commits intosbt:mainfrom
ASRagab:aragab/revive-nanoc
Open

Reviving NanocPlugin#212
ASRagab wants to merge 3 commits intosbt:mainfrom
ASRagab:aragab/revive-nanoc

Conversation

@ASRagab
Copy link
Copy Markdown

@ASRagab ASRagab commented Aug 19, 2023

Fixes

Additional Changes

  • I added a minimal .scalafmt.conf and plugin, I wanted to have a consistent formatting experience, also I updated the build process to also build for java 17. (can undo these changes, if they are not copacetic)

@lightbend-cla-validator
Copy link
Copy Markdown

Hi @ASRagab,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@ASRagab
Copy link
Copy Markdown
Author

ASRagab commented Aug 19, 2023

I have signed the updated CLA.

Copy link
Copy Markdown
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformatting made this PR look so much bigger. That's why I postponed looking closely for so long...

LGTM.

@ennru
Copy link
Copy Markdown
Contributor

ennru commented Feb 15, 2024

@ASRagab
Copy link
Copy Markdown
Author

ASRagab commented Feb 15, 2024

Oh no, I'll take a look.

Nanoc doesn't work properly in CI: https://github.com/sbt/sbt-site/actions/runs/7917374088/job/21613302634?pr=212#step:7:119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants