Challenge 2 readme suggestions #25
Open
Ifechukwudaniel wants to merge 3 commits intoscaffold-eth:challenge-2-sommelier-erc4626-adaptorfrom
Open
Challenge 2 readme suggestions #25Ifechukwudaniel wants to merge 3 commits intoscaffold-eth:challenge-2-sommelier-erc4626-adaptorfrom
Ifechukwudaniel wants to merge 3 commits intoscaffold-eth:challenge-2-sommelier-erc4626-adaptorfrom
Conversation
Collaborator
|
I like your idea of having a pre-reqs part of the README. I think we need to go through the README though and remove any repetitive links so as to not overwhelm the reader. I'll look at it with your recommendations and might make a commit to your repo PRing into this before approving it. |
Collaborator
|
Also not sure what you're PR message means when referring to "Your ENS/address:" |
Author
Yeah that was a mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Prerequisite section to the readme