feat: add --project and --name CLI flags for setting project name#384
Open
austintgriffith wants to merge 1 commit intomainfrom
Open
feat: add --project and --name CLI flags for setting project name#384austintgriffith wants to merge 1 commit intomainfrom
austintgriffith wants to merge 1 commit intomainfrom
Conversation
Adds the ability to specify the project name via named flags in addition to the existing positional argument support: - `--project` / `-p` / `--name` flags to set the project name - Updates help message to document the new options This allows for more explicit CLI usage: npx create-eth --project my-dapp --solidity-framework foundry
Collaborator
There was a problem hiding this comment.
This is useful for scripting and automation where named flags are clearer than positional arguments.
Just trying to understand, what error you get while using positional arg during scripting?
I am up for adding these flags, but I think all the major create- cli follow project name as positional arg only. Like create-next-app, create-vite app as well? Also since it's common pattern followed by other CLI's so AI might be good at it as well? So maybe we don't need this flag?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--project,-p, and--nameCLI flags to set the project name directly from the command linenpx create-eth my-project)Usage
This is useful for scripting and automation where named flags are clearer than positional arguments.
Test plan
yarn buildsucceedsyarn cli --project testapp --solidity-framework foundry --skip-installcreates project correctlyyarn cli testapp --solidity-framework foundry --skip-installyarn cli --help) shows new options