feat: reduce default pollingInterval from 30000ms to 3000ms#385
feat: reduce default pollingInterval from 30000ms to 3000ms#385austintgriffith wants to merge 1 commit intomainfrom
Conversation
The 30 second polling interval makes for a poor dev experience - most developers change this to a lower value immediately after starting a new project. Reducing the default to 3 seconds provides a snappier UX out of the box.
technophile-04
left a comment
technophile-04
left a comment
There was a problem hiding this comment.
Sounds good to me!
We had 30000 a while back so that we don't burn the RPC esprically the default mainnet RPC. But now we have 2 fallback for mainnet RPC.
And also I think now, most of the people deploy to L2's. So make sense to have it to be a lower value.
Just cc @carletex and @rin-st once.
Also while updating the core SE-2 files, the current flow is:
- We update that file in https://github.com/scaffold-eth/scaffold-eth-2 repo
- We do weekly or alternate week backmerge PR's from that repo to this eg: #69 (and those changes get auto-merged)
We planning to move everthing to this repo. So only this repo will be single source of truth. But currently we are following above flow (its a bit easy this way coz you update the thing in working repo instead of just templated files) but we plan to move out of this soon.
Wasn't only the mainnet RPC (which is true by default even for localhost), but also all the L2/testnets RPC calls that go against our default Alchemy key. But let's merge if you guys want, and keep an eye on how our alchemy key use changes. |
Yep, I agree too. And as Shiv said, let's recreate PR to se-2 instead of create-eth |
|
fixed on #386 |
4 participants
Summary
pollingIntervalinscaffold.config.tsfrom 30000ms (30 seconds) to 3000ms (3 seconds)Motivation
The 30 second polling interval makes for a poor dev experience - the UI feels slow and unresponsive when waiting for state updates. Almost every developer changes this to a lower value immediately after starting a new project.
Reducing the default to 3 seconds provides a snappier UX out of the box while still being reasonable for RPC rate limits.
Test plan