Skip to content

Update SKILL.md with pre-flight checks#148

Open
Pabl0cks wants to merge 2 commits intomainfrom
skill-tinkering
Open

Update SKILL.md with pre-flight checks#148
Pabl0cks wants to merge 2 commits intomainfrom
skill-tinkering

Conversation

@Pabl0cks
Copy link
Collaborator

Added pre-flight checks for project scaffolding steps.

Added pre-flight checks for project scaffolding steps.
@vercel
Copy link

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scaffold-eth-2-docs Ready Ready Preview, Comment Feb 24, 2026 2:36pm

Request Review

Comment on lines +20 to +22
2. **Resolve project name:** suggest a kebab-case name derived from what the user wants to build. Check if that directory already exists in the current location. If it does, auto-increment the suffix (`-2`, `-3`, etc.) until a free name is found.

3. **Important: Always confirm with the user if he wants to use the resolved <project-name>, and let him choose another one if he doesn't like resolved one.**. If the user choose another project name, use it as <project-name> in the next command.
Copy link
Member

@carletex carletex Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which issues did you have that you had to add these two? (just me thinking on keeping this as minimal as possible!)

  1. If this happens, the agent is usually smart enough (when it tries to install and fails because the dir exists)
Image
  1. It always asks me before running the npx command

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it decided to create a temp folder, and then try to move the scaffolded instance to the existing folder, it was a mess. 30+ minutes and then I started getting a lot of issues with symlink files:

  > 📁 Create project directory E:\GitHub\multisig-1shot-blank1
     × 📁 Create project directory E:\GitHub\multisig-1shot-blank1 [FAILED:
     Failed to create directory]
     … +84 lines (ctrl+o to see all)

● The directory already exists, so I'll scaffold to a temp name and move the files in.
image

I was using Sonnet 4.6

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried with the production SKILL.md and Opus 4.6 and it did just create a subfolder with the name he proposed, into my empty folder, which I think is OK.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it decided to create a temp folder, and then try to move the scaffolded instance to the existing folder,

I remember this happening to me once as well! But after that it never happened, it asks me for confirmation that poject already exisit, what you want to do? Remove, update the same one (tried with prod SKILL.md)

So I think maybe we can probably remove this two points 🙌

Copy link
Member

@rin-st rin-st Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me prompt worked fine on the first attempt, (macOS, foundry). Then, I tried to run the same script 4-5 times from the folder which is not scaffolded. Both [2] and [3] doesn't work for me. Both claude code and cursor never increment folder number and never asks for resolved project name. Just check if existing folder multisig-wallet scaffolded and then continue to work on the app inside the folder

Screenshot 2026-02-24 at 22 37 39 Screenshot 2026-02-24 at 22 39 33

I found the bug, from the BuidlGuidl/SpeedRunEthereum-v2#356 (comment), if add at the root of the folder everything works as expected.

# Build a Multisig Wallet dApp using Scaffold-ETH 2

If the current folder isn't scaffolded yet (no `packages/nextjs/scaffold.config.ts` at the root of the folder), follow the instructions at https://scaffold-eth-2-docs-git-skill-tinkering-buidlguidldao.vercel.app/SKILL.md to scaffold it.

If already scaffolded, continue directly with building.

It was breaking because I run the prompt from /buidl-guidl folder which has multiple projects and hence multiple packages/nextjs/scaffold.config.ts folders, but not on the root of the current folder. And that's why it behave that way

I'm wondering now why it worked first time. But it's AI, I think it's checked the link just in case and decided to go with it since it saw the way to build the app with create-eth


So, with that change on MacOS it asks
Screenshot 2026-02-24 at 23 08 21

and then asks again for create-eth command
image

Before running the scaffold command, do these pre-flight checks in order:

1. **Detect OS:** run `uname -o 2>/dev/null || echo "Windows"`.
- If output contains `Msys`, `Cygwin`, or `Windows` → use Hardhat. Do not check for Foundry. Foundry has known compatibility issues with create-eth on Windows.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, maybe you mentioned it in some other discussion but what error are getting? I think it would be nice to handle it asap

But for time being we can keep this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants