Skip to content

Conversation

blaz-kranjc
Copy link
Contributor

@blaz-kranjc blaz-kranjc commented Apr 15, 2023

Fixes #2735

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (ebc36a3) 90.96% compared to head (a29746c) 90.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3033      +/-   ##
==========================================
+ Coverage   90.96%   90.98%   +0.02%     
==========================================
  Files         160      160              
  Lines        3341     3351      +10     
  Branches      303      308       +5     
==========================================
+ Hits         3039     3049      +10     
  Misses        302      302              
Impacted Files Coverage Δ
...g/scalasteward/core/repoconfig/RepoConfigAlg.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for ignoring your PR for so long.
Thank you for your contribution.

@mzuehlke mzuehlke added the enhancement New feature or request label May 7, 2023
@mzuehlke mzuehlke added this to the 0.24.0 milestone May 7, 2023
@mzuehlke mzuehlke merged commit b699957 into scala-steward-org:main May 7, 2023
@blaz-kranjc blaz-kranjc deleted the feature/add-support-for-multiple-conf-locations branch May 7, 2023 12:35
@mkurz
Copy link
Contributor

mkurz commented Jul 10, 2023

The .github and .config folder are both meant to be hidden (prefixed with a dot) and the .scala-steward.conf in the root folder is meant to be hidden as well.

Now, wouldn't it make sense to support a (non-hidden) scala-steward.conf within the .github and .config folder since both folder are hidden already?

E.g. look at how mergify does it (https://docs.mergify.com/configuration/)

Mergify uses the configuration file that is:

  • The file named .mergify.yml, or, as a fallback, .mergify/config.yml or .github/mergify.yml from the root directory.

@mkurz
Copy link
Contributor

mkurz commented Jul 10, 2023

Opened #3115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback to .github/.scala-steward.conf if config not found in root

3 participants