Support GitHub Enterprise#3456
Merged
mzuehlke merged 1 commit intoscala-steward-org:mainfrom Nov 17, 2024
Merged
Conversation
Contributor
Author
|
@exoego @alejandrohdezma Ready for review |
Contributor
Author
Member
|
Thanks @joan38 for the pull request. |
Contributor
Author
|
Thanks @mzuehlke let me know your thoughts on this |
Contributor
Author
|
I'm trying one more ping on this 😞 |
mzuehlke
approved these changes
Nov 15, 2024
Member
mzuehlke
left a comment
mzuehlke
left a comment
There was a problem hiding this comment.
Thanks for the contribution @joan38
Compared to your first attempt you cut the changes to a third 👍
I appreciate that you managed keep the CLI unchanged.
I hope that this helps with the adoption of Scala Steward @ Netflix 🚀
And sorry that I didn't managed to review this earlier 😢
Contributor
Author
|
Thanks @mzuehlke, this is great! What is the next step now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #3425 but reduced as much as possible