Add whitelist organizations option#3589
Open
lenguyenthanh wants to merge 3 commits intoscala-steward-org:mainfrom
Open
Add whitelist organizations option#3589lenguyenthanh wants to merge 3 commits intoscala-steward-org:mainfrom
lenguyenthanh wants to merge 3 commits intoscala-steward-org:mainfrom
Conversation
This is to solve issue that UrlChecker cannot check a private github repository exist or not. As github ignore authentication tokens for all url except one start with `api`. This adds: - Add cli option to add whitelist organization(s) - For all url belong to a whitelisted organization, UrlChecker will skip checking it and UpdateInfoUrlFinder will skip guessing possible urls
lenguyenthanh
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3589 +/- ##
==========================================
+ Coverage 89.80% 89.83% +0.03%
==========================================
Files 174 174
Lines 5031 5047 +16
Branches 493 488 -5
==========================================
+ Hits 4518 4534 +16
Misses 513 513 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I just realized even with my last commit, it is still not cover all possible case, for example it'll doesn't work with private gitlab instance. I'll try to solve this, in the mean time any suggestions are welcomed. |
Contributor
Author
|
hello again, I would love to have some feedback from maintainers if this approach is welcomed. I'm opened to any feedback even start it from scratch if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to solve #1468 (comment). This add a cli option to whitelist organization(s) from
UrlCheckermore details in the first commit's message.Another option is a to add this option in
RepoConfigwhich in my opinion, is a better solution than this pr. But I didn't think about it until I was about to make this pr 😅 . I could do a pr for this option if you think it's indeed better.