Closed
Conversation
rtyley
force-pushed
the
add-dependency-cooldowns-redux-after-pr-3787
branch
3 times, most recently
from
b5aa227 to
8ceff43
Compare
rtyley
changed the base branch from
replace-update-ForArtifactId-NewerVersions-with-ArtifactUpdateCandidates
to
single-update-does-not-need-withNextVersion
rtyley
force-pushed
the
single-update-does-not-need-withNextVersion
branch
from
6a33604 to
39325bd
Compare
Add deserialisation test for VersionsCache Value Add json fixture for new Value type Add VersionWithFirstSeen Add merging of new and old first-seen version data Add deserialisation test for new format It looks like we probably want to update UpdatesConfig.scala to add a new method `isTooNew: Update.ForArtifactId => FilterResult` which rules out proposed updates that use too new a version (according to the user’s config). To do that, we reckon we’ll need Update.ForArtifactId to list versions with their firstSeen information, i.e. update the contained type from Version to VersionWithFirstSeen. This commit begins making that change (and so will not compile). Replace withNewerVersions with supersedes This commit removes withNewerVersions and replaces the one usage of it with a new function supersedes, which checks whether an update matches another while having a newer nextVersion. withNewerVersions was a little awkward to update to work with us having changed some Versions to VersionWithFirstSeens, because it accepts a list of Versions (rather than just producing one). It was originally added in response to [this PR comment](#1667 (comment)), but we reckon replacing it with a slightly different check of the group and artifact IDs makes for clearer, more explicit code. We think (though it’s somewhat hard to tell) that this doesn’t remove any existing functionality: part of the argument for adding withNewerVersions in the first place was to support Update.Group, but it appears to only be called for Update.Singles. Add CooldownConfig To facilitate using dependency cooldowns, this commit adds a class CooldownConfig to represent a user’s desired cooldown settings: a list of ages (specified as finite durations, using the same string syntax as supported for pullRequests.frequency), each with a list of UpdatePatterns for the age to apply to. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk> # Conflicts: # modules/core/src/main/scala/org/scalasteward/core/data/Update.scala
rtyley
force-pushed
the
add-dependency-cooldowns-redux-after-pr-3787
branch
from
8ceff43 to
85d78db
Compare
rtyley
changed the base branch from
single-update-does-not-need-withNextVersion
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is a temporary redo of:
...rebased on top of:
newerVersionsfromUpdates #3787...this draft PR is just a place for examining the alternative branch, to see if it should be folded back into #3762 .