Skip to content

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 22, 2024

fixes #3095

@SethTisue SethTisue force-pushed the kill-old-closure-page branch from 7005f75 to c024cbd Compare October 22, 2024 15:00
@SethTisue SethTisue merged commit 905ed27 into scala:main Oct 26, 2024
1 check passed
@SethTisue SethTisue deleted the kill-old-closure-page branch October 26, 2024 19:36
fResult pushed a commit to fResult/docs.scala-lang that referenced this pull request Oct 27, 2024
@Flowdalic
Copy link
Contributor

FYI, https://docs.scala-lang.org/tour/automatic-closures.html still exists and is accessible. I am not sure if this should be the case.

@SethTisue
Copy link
Member Author

@fsalvi is this one of those things where the website publishing only adds files but doesn't delete them?

do you have any clue why the redirect_from in this PR isn't doing its job...?

@fsalvi
Copy link
Contributor

fsalvi commented Sep 23, 2025

To avoid any disaster during the build & deploy job, the rsync command to the website doesn't delete existing files, this is why the file was still present. I forced it manually to delete, now the file is not present anymore and you get a 404 error.
The redirect_from works fine, but with the URI "/tutorials/tour/automatic-closures.html" (not /tour/automatic-closures.html).

@SethTisue
Copy link
Member Author

thanks! added more redirects in 2728dd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orphan page in language tour: "Automatic Type-Dependent Closure Construction"
3 participants