Skip to content

Conversation

Gedochao
Copy link
Contributor

Fixes #3206

@Gedochao Gedochao changed the title Update the nightlies doc to mention repo.scala-lang.org Update the nightlies doc to mention repo.scala-lang.org Sep 16, 2025
@Gedochao Gedochao force-pushed the maintainance/update-nightlies-doc branch 3 times, most recently from 08bece9 to 69bb7c6 Compare September 16, 2025 12:17

Note how the custom `JvmWorkerModule` is necessary with the added repository. It is not enough to just define it as a repository for the module dependencies.

Also note that Mill 1.0.5 or newer is necessary for this.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: 1.0.5 is not out yet, although as per Discord discussion, it should be out soon.
Example was tested with Mill 1.0.4-53-a211b4 (it's already working on the nightly Mill version).
cc @lihaoyi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mill 1.0.5 is freshly out, so that's solved.
https://github.com/com-lihaoyi/mill/releases/tag/1.0.5

@Gedochao Gedochao changed the title Update the nightlies doc to mention repo.scala-lang.org Update the nightlies doc Sep 16, 2025
@Gedochao Gedochao force-pushed the maintainance/update-nightlies-doc branch from 69bb7c6 to 94fbd48 Compare September 16, 2025 12:59
//> using scala 2.nightly
### SBT

### Longer explanation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Longer explanation section feels redundant now, at least for the scope of this document, so I ended up removing it.
repo.scala-lang.org proxies to Scala 2 nightlies, so that part is basically an implementation detail.
Let me know if we want to preserve it somewhere.
cc @SethTisue @lrytz

@Gedochao
Copy link
Contributor Author

Since repo.scala-lang.org proxies to Scala 2 nightlies, I ended up merging the Scala 2 and 3 sections to a large extent, and removed some stuff that no longer feels necessary.
Feel free to stop me.

@Gedochao Gedochao force-pushed the maintainance/update-nightlies-doc branch 2 times, most recently from 942a799 to f6abe39 Compare September 16, 2025 13:06
@Gedochao Gedochao force-pushed the maintainance/update-nightlies-doc branch 2 times, most recently from 11c2739 to 6841130 Compare September 16, 2025 14:29
@SethTisue
Copy link
Member

I think this is now mergeable, and I suggest we merge it promptly, to make the information available now.

I have some ideas for tweaks and adjustments, but I can put that in a separate PR.

@SethTisue
Copy link
Member

maybe the "Longer explanation" part could be internal documentation in https://github.com/scala/internal-docs instead?

@Gedochao Gedochao force-pushed the maintainance/update-nightlies-doc branch from 6841130 to 40c7c93 Compare September 17, 2025 05:28
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

For Scala 2, the easiest way to find a specific mergely version number is to go to https://github.com/scala/scala/commits/2.13.x, find the merge commit that you want to try out, click on the "checks", scroll down to the one from travis. The version number shows up there.

image

Mabye that could be included?

@Gedochao Gedochao force-pushed the maintainance/update-nightlies-doc branch from 40c7c93 to 2319e2d Compare September 17, 2025 10:18
@Gedochao
Copy link
Contributor Author

Looks good, thank you!

For Scala 2, the easiest way to find a specific mergely version number is to go to https://github.com/scala/scala/commits/2.13.x, find the merge commit that you want to try out, click on the "checks", scroll down to the one from travis. The version number shows up there.

image Mabye that could be included?

IMO that's a bit complex, while one can find it way easier at https://repo.scala-lang.org/artifactory/maven-nightlies or via Scala CLI... we can mention it in internal docs, but perhaps not in user facing ones.
@hamzaremmal's been suggesting to cut out stuff simpler than that from here already 😅

@hamzaremmal
Copy link
Member

@hamzaremmal's been suggesting to cut out stuff simpler than that from here already 😅

Yes, suggesting to people all of these steps is just wrong. We should fine a better way. For now, I think it's okay. I will do a last review now and approve it.

@Gedochao Gedochao merged commit 8003014 into scala:main Sep 17, 2025
1 check passed
@Gedochao Gedochao deleted the maintainance/update-nightlies-doc branch September 17, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "nightlies" page for new Scala 3 nightlies repository
4 participants