Skip to content

Commit c80cfe4

Browse files
authored
Merge pull request #275 from SethTisue/version-bumps
bump some versions (Scala, MiMa)
2 parents 838180b + 7b3b80e commit c80cfe4

File tree

5 files changed

+21
-11
lines changed

5 files changed

+21
-11
lines changed

.travis.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ language: scala
66

77
scala:
88
- 2.11.12
9-
- 2.12.8
10-
- 2.13.0
9+
- 2.12.10
10+
- 2.13.1
1111

1212
env:
1313
- SCALAJS_VERSION= ADOPTOPENJDK=8
@@ -22,15 +22,15 @@ matrix:
2222
include:
2323

2424
# run migration test
25-
- scala: 2.12.8
25+
- scala: 2.12.10
2626
env: TEST_SCALAFIX=true ADOPTOPENJDK=8
2727

2828
# run binary compatibility test
29-
- scala: 2.12.8
29+
- scala: 2.12.10
3030
env: TEST_BINARY_COMPAT=true ADOPTOPENJDK=8
3131

3232
# run scalafmt
33-
- scala: 2.12.8
33+
- scala: 2.12.10
3434
env: TEST_SCALAFMT=true ADOPTOPENJDK=8
3535

3636
# Scala Native includes

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ The library also adds backported versions of new collection types, currently `sc
3939

4040
## Migration Tool
4141

42-
The migration rules use scalafix. Please see the [official installation instruction](https://scalacenter.github.io/scalafix/docs/users/installation.html) and, in particular, check that your full Scala version is supported (ex 2.12.8).
42+
The migration rules use scalafix. Please see the [official installation instruction](https://scalacenter.github.io/scalafix/docs/users/installation.html) and, in particular, check that your full Scala version is supported (ex 2.12.10).
4343

4444
```scala
4545
// project/plugins.sbt

binary-compat/test/src/test/scala/BinaryCompaTest.scala

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,16 @@ class BinaryCompaTest {
2323
Config.setup("foo", Array(oldClasspath, newClasspath))
2424
val mima = new MiMaLib(Config.baseClassPath)
2525
val allProblems = mima.collectProblems(oldClasspath, newClasspath)
26-
Assert.assertEquals(allProblems, Nil)
26+
val unexpectedDescriptions =
27+
allProblems.iterator
28+
.map(_.description("new"))
29+
.map{x => println(x); x}
30+
.filterNot(_ == "static method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in class org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;")
31+
.filterNot(_ == "method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in object org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;")
32+
.toList
33+
val msg =
34+
unexpectedDescriptions.mkString(
35+
s"The following ${allProblems.size} problems were reported but not expected:\n - ", "\n - ", "\n")
36+
Assert.assertEquals(msg, Nil, unexpectedDescriptions)
2737
}
2838
}

build.sbt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ lazy val root = project
4747
lazy val junit = libraryDependencies += "com.novocode" % "junit-interface" % "0.11" % Test
4848

4949
lazy val scala211 = "2.11.12"
50-
lazy val scala212 = "2.12.8"
51-
lazy val scala213 = "2.13.0"
50+
lazy val scala212 = "2.12.10"
51+
lazy val scala213 = "2.13.1"
5252

5353
/** Create an OSGi version range for standard Scala versioning
5454
* schemes that describes binary compatible versions. */
@@ -139,7 +139,7 @@ lazy val `binary-compat` = project
139139
.settings(commonSettings)
140140
.settings(
141141
scalaVersion := scala212,
142-
libraryDependencies += "com.typesafe" %% "mima-reporter" % "0.3.0" % Test,
142+
libraryDependencies += "com.typesafe" %% "mima-core" % "0.6.1" % Test,
143143
junit,
144144
buildInfoPackage := "build",
145145
buildInfoKeys := Seq[BuildInfoKey](

project/MultiScalaProject.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import java.io.File
2222
*
2323
* // instanciate a sbt project
2424
* lazy val myProject211 = myProject("2.11.12", _.settings(...) /* scala version dependent configurations */)
25-
* lazy val myProject212 = myProject("2.12.8" , _.settings(...))
25+
* lazy val myProject212 = myProject("2.12.10" , _.settings(...))
2626
* // ...
2727
* }}}
2828
*/

0 commit comments

Comments
 (0)