Backport "Check exhaustivity of any case class" to 3.3 LTS #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
backport-lts-3.3-22604
branch
from
cbac513 to
3ec2223
Compare
tgodzik
force-pushed
the
backport-lts-3.3-22604
branch
from
4dbff7f to
8b2f2c3
Compare
|
No regressions detected in the community build up to backport-lts-3.3-22604. |
He-Pin
reviewed
Aug 30, 2025
| case (`passedEnd`, r: U @unchecked) => (thisElem, r) | ||
| case (l: A @unchecked, `passedEnd`) => (l, thatElem) | ||
| case t: (A, U) @unchecked => t // false-positive warning | ||
| case (t1, t2) => (t1, t2) |
There was a problem hiding this comment.
The actual code in Akka/Pekko doesn't have the case (t1, t2) => (t1, t2)
There was a problem hiding this comment.
Reverting in #582 and for the next RC scala#23943
tgodzik
added a commit
that referenced
this pull request
Sep 19, 2025
Revert "Merge pull request #275 from scala/backport-lts-3.3-22604"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#22604 to the 3.3.7.
PR submitted by the release tooling.