Backport "Test chars safely when highlighting" to 3.3 LTS #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arrow test at lastOffset - 3 is out-of-range when highlighting, which parses a snippet of source. Always check lower bound in testChar. Don't check as initial condition in testChars because it recurses. [Cherry-picked fb6cc9b][modified]
tgodzik
force-pushed
the
backport-lts-3.3-22918
branch
from
14bbc08 to
48d19ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#22918 to the 3.3.7.
PR submitted by the release tooling.