Skip to content

Backport "Warn unused masking imports, remove obsolete unused options" to 3.3 LTS #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: backport-lts-3.3-23792
Choose a base branch
from
Open

Backport "Warn unused masking imports, remove obsolete unused options" to 3.3 LTS #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61cdcae
Remove unused code
som-snytt Aug 17, 2025
4de57e7
Remove unused code
tgodzik Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import dotty.tools.dotc.core.Names.{Name, SimpleName, DerivedName, TermName, ter
import dotty.tools.dotc.core.NameOps.{isAnonymousFunctionName, isReplWrapperName, isContextFunction, setterName}
import dotty.tools.dotc.core.NameKinds.{
BodyRetainerName, ContextBoundParamName, ContextFunctionParamName, DefaultGetterName, WildcardParamName}
import dotty.tools.dotc.core.Scopes.newScope
import dotty.tools.dotc.core.StdNames.nme
import dotty.tools.dotc.core.Symbols.{ClassSymbol, NoSymbol, Symbol, defn, isDeprecated, requiredClass, requiredModule}
import dotty.tools.dotc.core.Types.*
Expand Down Expand Up @@ -702,8 +703,7 @@ object CheckUnused:
import scala.jdk.CollectionConverters.given
import Rewrites.ActionPatch
type ImpSel = (Import, ImportSelector)
def isUsable(imp: Import, sel: ImportSelector): Boolean =
sel.isImportExclusion || infos.sels.containsKey(sel) || imp.isLoose(sel)
def isUsed(sel: ImportSelector): Boolean = infos.sels.containsKey(sel)
def warnImport(warnable: ImpSel, actions: List[CodeAction] = Nil): Unit =
val (imp, sel) = warnable
val msg = UnusedSymbol.imports(actions)
Expand Down Expand Up @@ -1003,12 +1003,6 @@ object CheckUnused:
def boundTpe: Type = sel.bound match
case untpd.TypedSplice(tree) => tree.tpe
case _ => NoType
/** This is used to ignore exclusion imports of the form import `qual.member as _`
* because `sel.isUnimport` is too broad for old style `import concurrent._`.
*/
def isImportExclusion: Boolean = sel.renamed match
case untpd.Ident(nme.WILDCARD) => true
case _ => false

extension (imp: Import)(using Context)
/** Is it the first import clause in a statement? `a.x` in `import a.x, b.{y, z}` */
Expand Down