Handle super accessors in initialization checker #15703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
approved these changes
Jul 19, 2022
| def foo(): Int = m | ||
|
|
||
| class N extends A with B: | ||
| override def foo(): Int = 10 * super.foo() |
There was a problem hiding this comment.
Should this test have an additional field to ensure that this def foo is not considered to be called during initialization (like the n field in the other test)?
| // Note that a parameterized trait may only get parameters from the class that extends the trait. | ||
| // A trait may not supply constructor arguments to another trait. | ||
| if !klass.is(Flags.Trait) then | ||
| for parent <- klass.parentSyms if parent.hasSource do doPromote(parent.asClass, klass, isHotSegment) |
There was a problem hiding this comment.
Why is it OK to remove this? We don't need to promote super-trait segments? Is it because it is duplicated by the promotion of mixins below?
There was a problem hiding this comment.
Yes, with the changes we avoid some duplicate check (with cache they are not expensive though):
trait A
class B extends A
class C extends B with A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle super accessors in initialization checker