Skip to content

Fix tuple member selection so it works with GADT healing #16766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix tuple member selection so it works with GADT healing #16766

merged 1 commit into from
Jan 26, 2023

Conversation

dwijnand
Copy link
Member

No description provided.

@dwijnand dwijnand linked an issue Jan 25, 2023 that may be closed by this pull request
Can't call ._1 on values inferred by a GADT match to be a tuple #16590
Closed
@SethTisue
Copy link
Member

SethTisue commented Jan 25, 2023 •
edited
Loading

This not only fixes the bug but is IMO elegant 👍

@dwijnand dwijnand marked this pull request as ready for review January 25, 2023 19:04
@dwijnand dwijnand requested a review from abgruszecki January 25, 2023 19:04
@dwijnand dwijnand merged commit f545d10 into scala:main Jan 26, 2023
@dwijnand dwijnand deleted the gadt-selecting-on-generic-tuple branch January 26, 2023 22:26
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abgruszecki abgruszecki abgruszecki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abgruszecki abgruszecki

Labels

None yet

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

Can't call ._1 on values inferred by a GADT match to be a tuple

4 participants

@dwijnand @SethTisue @abgruszecki @Kordyjan