Skip to content

Enrich and finesse compiler crash reporting #17031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2023
Merged

Enrich and finesse compiler crash reporting #17031

merged 3 commits into from
Mar 6, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Mar 1, 2023 •
edited
Loading

  • Change trytoShow's to not use raw string
  • Add an enrichedErrorMessage on Run, so to only handle the first exception

Some of the changes from #16685.

@dwijnand dwijnand marked this pull request as ready for review March 2, 2023 08:48
@dwijnand dwijnand requested a review from odersky March 2, 2023 08:48
@SethTisue
Copy link
Member

SethTisue commented Mar 2, 2023 •
edited
Loading

This looks like a good core of uncontroversial (I think) yet highly beneficial changes to land.

Perhaps some of the rest of #16685 and/or #16593 could eventually land as separate followup PRs.

cc @robmwalsh

odersky
odersky approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Looks like a great improvement!

@odersky odersky assigned dwijnand and unassigned odersky Mar 6, 2023
odersky
odersky requested changes Mar 6, 2023
View reviewed changes
@dwijnand
Unduplicate enrich{,ed}ErrorMessage
099f9f2 
Having a same-named enrichement will cause the original to be called
if/when explicit nulls is switched off - which leads to the original
method to be called, meaning an NPE will be thrown.

So, instead, move all the functionality as an extension method, so we
don't need mangled names.
@dwijnand dwijnand merged commit f92d6f1 into scala:main Mar 6, 2023
@dwijnand dwijnand deleted the crash-informer branch March 6, 2023 20:58
@SethTisue SethTisue mentioned this pull request Mar 21, 2023
Closed
@arturaz arturaz mentioned this pull request Mar 30, 2023
Closed
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odersky odersky odersky approved these changes

Assignees

@dwijnand dwijnand

Labels

None yet

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dwijnand @SethTisue @odersky @Kordyjan