Fix: Corret the PR17229 with the tests failing #17958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit: - Added a error message when the path of a page is wrong - Added an error message when an inddex or a page path in a subsection is missing - Added an error message when a title in a subsection is missing
- Change the case match (Overkill) to a if else - Two types of messages : - Error: NoTitle and No index or No page. - Warning: When the parsing is not done correctly. Example: When a title got two pages.
- Error when a title but no pages
- Do a new method of test (Use a 'contains' instead) - Improve the accuracy of the error message by putting variables.
Dedelweiss
force-pushed
the
fix-17229-error-sidebar
branch
from
2afb0f7 to
73fd8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this Pull request is to correct my PR #17229
Sorry for this failure.
I have tested the following command locally and my tests pass.
sbt ";dist/pack ;scala3-bootstrapped/compile ;scala3-bootstrapped/test"