Better refinement symbols in semanticDB#18604
Draft
jkciesluk wants to merge 1 commit intoscala:mainfrom
Draft
Conversation
Gedochao
added
the
stat: stale PR
Contributor
|
@tanishiking @rochala @natsukagami is this still relevant? Do you mean to work on this in the near future, or should we close it? |
Contributor
It does still seem relevant, we would have to rebase an make sure it all still passes. I will take a look |
tgodzik
force-pushed
the
semanticdb-refl
branch
2 times, most recently
from
71f709e to
9652846
Compare
Previosuly all `Select` on refined types have had symbol from `reflect.Selectable` and their definitions were not global. This change should improve navigation and rename in Metals and allow further changes in presentation compiler module, in order to provide better highlighting and hover
tgodzik
force-pushed
the
semanticdb-refl
branch
from
9652846 to
a66dd3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosuly all
Selecton refined types have had symbol fromreflect.Selectableand their definitions were not global. This change should improve navigation and rename in Metals and allow further changes in presentation compiler module, in order to provide better highlighting and hover