Show git diff command on checkfile failure
#19308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff is more familiar and consistent across systems. We can assume
that all developers of Dotty have git installed.
When a checkfile fails we now show
```diff
Test output dumped in: tests/run/xyz.check.out
- See diff of the checkfile (`brew install icdiff` for colored diff)
- > diff tests/run/xyz.check tests/run/xyz.check.out
+ See diff of the checkfile (`--color=always` for colored diff)
+ > git diff --no-index -- tests/run/xyz.check tests/run/xyz.check.out
Replace checkfile with current output
> mv tests/run/xyz.check.out tests/run/xyz.check
```
nicolasstucki
force-pushed
the
show-git-diff-command-on-checkfile-failure
branch
from
4e88857 to
b5479c5
Compare
bishabosha
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff is more familiar and consistent across systems. We can assume that all developers of Dotty have git installed.
When a checkfile fails we now show