Skip to content

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 16, 2024

backports #18525 , which was on the "Scala 3.3 LTS backports" project board but seems to have been overlooked

@Kordyjan is it too late for this to make 3.3.2...?

fyi @lrytz

yes, I think we should ship this even though 2.13.13 is coming soon

@SethTisue SethTisue added this to the 3.3.2 milestone Jan 16, 2024
@SethTisue SethTisue changed the title Scala 2.13.12 Scala 2.13.12 (was 2.13.10) Jan 16, 2024
@SethTisue SethTisue requested a review from Kordyjan January 16, 2024 02:48
Copy link
Contributor

@Kordyjan Kordyjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a single comment, everything looks good. We can have it in 3.3.2.

It also reminds me that we will probably be unable to bump Scala 2 standard library versions in the LTS once scala/improvement-proposals#54 is in effect. This needs some discussion.

Comment on lines -855 to 857
|experimental scala.languageFeature
|higherKinds scala.languageFeature
|implicitConversions scala.languageFeature
|postfixOps scala.languageFeature
|""".stripMargin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why did it change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be related to #19468

@lrytz
Copy link
Member

lrytz commented Jan 22, 2024

we will probably be unable to bump Scala 2 standard library versions in the LTS once scala/improvement-proposals#54 is in effect

Is this for technical reasons or not?

@SethTisue SethTisue marked this pull request as ready for review January 22, 2024 15:00
@SethTisue
Copy link
Member Author

will merge-conflict in one place with #19492, easily resolved

@SethTisue SethTisue merged commit 3cac39e into scala:release-3.3.2 Jan 30, 2024
@SethTisue SethTisue deleted the scala-2.13.12-for-3.3.2 branch January 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants