fix/scripts: Propagate runner JVM version and skip testing invalid compiler commits #19656
Conversation
|
|
||
| def tmpScalaCliScript(command: String, args: Seq[String]): File = tmpScript(s""" | ||
| |#!/usr/bin/env bash | ||
| |export JAVA_HOME=${sys.props("java.home")} |
There was a problem hiding this comment.
Any specific reason to override JAVA_HOME instead of passing the java version to scala-cli via --jvm option?
Also, this won't be taken into account when using a custom validation script. Is this intentional?
There was a problem hiding this comment.
I assume that user of custom validation script is an advanced user who understands not only a tested code, but also the environment in which it is being run. Especially since custom bisect script might use sbt or other build tool. We could add custom JAVA_HOME to custom scripts by populating env variables of created process, but it would require a rewrite for parts of the code. I'd try this approach and check how it behaves.
The JAVA_HOME was used instead of --jvm argument to make sure that we exactly the same JVM version. We would not be able to pass a path in --jvm argument, and extraction of --jvm argument might be difficult.
3 participants
Fixes #19650
scala-cli run project/scripts/bisect.scala --jvm=21 -- <bisect args>