added HashTableBuilder.rootNode to white list #19943
Conversation
| end if | ||
|
|
||
| // class body | ||
| val whiteList = Set("scala.collection.immutable.Vector.emptyIterator") |
There was a problem hiding this comment.
We should use a Definition here (from dotty.tools.dotc.core.Definitions) instead of a plain String, unless there is some reason not to.
|
Could you also please add description & problem this PR fixes, as there is no issue attached? |
|
This is a step towards fixing #18882 . |
| case vdef : ValDef if !vdef.symbol.is(Flags.Lazy) && !vdef.rhs.isEmpty => | ||
| val res = eval(vdef.rhs, thisV, klass) | ||
| val sym = vdef.symbol | ||
| var res = if (whiteList.contains(sym)) Bottom else eval(vdef.rhs, thisV, klass) |
|
It turns out that adding |
szymon-rd
changed the title
|
@liufengyun Could you take a look, please? |
| end if | ||
|
|
||
| // class body | ||
| val whiteList = Set(HashSetBuilder_rootNode) |
There was a problem hiding this comment.
I would move it to be a field of the class Objects.
There was a problem hiding this comment.
I was wondering what if we add the following fields to the whitelist:
scala.collection.immutable.SetNode.EmptySetNodehttps://github.com/scala/scala/blob/2.13.x/src/library/scala/collection/immutable/HashSet.scala#L384scala.collection.immutable.HashSet.EmptySethttps://github.com/scala/scala/blob/2.13.x/src/library/scala/collection/immutable/HashSet.scala#L1934
5 participants
No description provided.