Skip to content

Add checkfile for ScalaCheck #20388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2024
Merged

Add checkfile for ScalaCheck #20388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/init-global/warn/ScalaCheck.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
-- Warning: tests/init-global/warn/ScalaCheck.scala:16:9 ---------------------------------------------------------------
16 | object OptMinSuccess extends IntOpt: // warn
| ^
| Cyclic initialization: object OptMinSuccess -> object FirstParser -> object OptMinSuccess. Calling trace:
| ├── object OptMinSuccess extends IntOpt: // warn [ ScalaCheck.scala:16 ]
| │ ^
| ├── object FirstParser extends CmdLineParser: [ ScalaCheck.scala:15 ]
| │ ^
| └── val opts = Some(OptMinSuccess) [ ScalaCheck.scala:21 ]
| ^^^^^^^^^^^^^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I introduced the problem. As a quick fix, you can change List to Some in the original test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, it is indeed working locally with the scala2_library_tasty

2 changes: 1 addition & 1 deletion tests/init-global/warn/ScalaCheck.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ object FirstParser extends CmdLineParser:
val names = Set("bla")
val help = "bla"

val opts = List(OptMinSuccess)
val opts = Some(OptMinSuccess)
val a = "FirstParser"