Skip to content

Conversation

kasiaMarek
Copy link
Member

@kasiaMarek kasiaMarek commented Jun 10, 2024

@kasiaMarek kasiaMarek requested a review from tgodzik June 10, 2024 13:17
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite

@kasiaMarek
Copy link
Member Author

Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite

It's the same thing as here: scalameta/metals#6482 (comment). The compiler seems to randomly choose ordering here.

@tgodzik
Copy link
Contributor

tgodzik commented Jun 11, 2024

Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite

It's the same thing as here: scalameta/metals#6482 (comment). The compiler seems to randomly choose ordering here.

Why did it never pop up before though 🤔 Let's make sure the test is solid before merging, since everyone else would be really unhappy about an additional flaky test

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tgodzik tgodzik merged commit 61a15b2 into scala:main Jun 13, 2024
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
WojciechMazur added a commit that referenced this pull request Jul 10, 2024
Backports #20542 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants