Change the trigger to check the CLA #20567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added a commit
that referenced
this pull request
Jun 14, 2024
This reverts commit e4a5d9c.
hamzaremmal
added a commit
that referenced
this pull request
Jun 14, 2024
Reverts #20567 It turns out to be a bad idea, PRs only keep the status of the jobs of the last commit. Therefore, we will always have a the CLA job that is not reported... I've played around in a different repository to test which is best but this new trigger is very much useless in our use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the trigger to check the Scala CLA to the PR creation. It avoids wasting resources by checking the CLA on each push to an open PR.
It also cleans the workflow by removing unnecessary triggers such as
pushandmerge_groupsince it was previously filtered in the job.It also removes unnecessary permissions.