Skip to content

fix: semanticdb symbol creation when targetName set #20950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: semanticdb symbol creation when targetName set #20950

merged 1 commit into from
Jul 3, 2024

Conversation

kasiaMarek
Copy link
Member

@kasiaMarek kasiaMarek marked this pull request as ready for review July 3, 2024 09:16
@kasiaMarek kasiaMarek requested a review from tgodzik July 3, 2024 09:16
tgodzik
tgodzik approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit ea1116d into scala:main Jul 3, 2024
@kasiaMarek kasiaMarek mentioned this pull request Jul 10, 2024
Closed
@WojciechMazur WojciechMazur mentioned this pull request Jul 10, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 11, 2024
@WojciechMazur
Backport "fix: semanticdb symbol creation when targetName set" to L…
839359b 
…TS (#21167)

Backports #20950 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Aug 27, 2024
Merged
WojciechMazur added a commit that referenced this pull request Aug 27, 2024
@WojciechMazur
Backport "fix: semanticdb symbol creation when targetName set" to 3…
ef39a28 
….5.2 (#21446)

Backports #20950 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@kasiaMarek @tgodzik @WojciechMazur