Skip to content

Backport "Avoid crash after StopMacroExpansion" to LTS #20979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

Backport "Avoid crash after StopMacroExpansion" to LTS #20979

merged 2 commits into from
Jul 3, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #19883 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

dwijnand added 2 commits July 3, 2024 00:05
@dwijnand @WojciechMazur
Avoid crash after StopMacroExpansion
c848109 
When a splice throws a StopMacroExpansion, it's replaced by an
EmptyTree, which has NoType.  Which means you can't cast it, as you
can't call .asInstanceOf on it.  So handle this before calling
ensureConforms.

[Cherry-picked 44aa3c6]
@dwijnand @WojciechMazur
Use ??? instead of EmptyTree for StopMacroExpansion.
37abd28 
[Cherry-picked 0fe0490]
Base automatically changed from lts-19884 to lts-3.3 July 3, 2024 08:38
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-19921.

Reference

@WojciechMazur WojciechMazur merged commit 77048cc into lts-3.3 Jul 3, 2024
@WojciechMazur WojciechMazur deleted the lts-19883 branch July 3, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WojciechMazur @dwijnand